You're simply surpressing the error with that. It doesn't do anything about the problem. Probably fopen url wrapper aren't enabled so you can't grab remote pages.
That doesn't do anything, @ is simply error supression. The curl library -- if your host supports it -- would be the only way to do do link checks or anything else that requries grabbing a remote url when your host has disabled fopen url wrappers. And surely if your host does support them, it wouldn't give an error.
Well the Get META function works well with @ in that place. Without the @, it doesn't. I have no idea why, just thought reporting this could be helpful in some way.
0/5
1
2
3
4
5
This thread is closed, so you cannot post a reply.
Comments on Missing @ in filefunctions.php
Member
Usergroup: Customer
Joined: Oct 24, 2004
Location: Sweden
Total Topics: 5
Total Comments: 12
Found that a @ is missing on line 126 filefunctions.php
$filecontents = file_get_contents($url);
shoud be
$filecontents = @file_get_contents($url);
(As it was in earlier versions for example 3.12)
This causes errors in get META description and Dead link checks.
developer
Usergroup: Administrator
Joined: Dec 20, 2001
Location: Diamond Springs, California
Total Topics: 61
Total Comments: 7868
You're simply surpressing the error with that. It doesn't do anything about the problem. Probably fopen url wrapper aren't enabled so you can't grab remote pages.
I'll be looking into curl support in the future.
Member
Usergroup: Customer
Joined: Oct 24, 2004
Location: Sweden
Total Topics: 5
Total Comments: 12
Now I'm grabbing remote pages just fine and downcheck doesn't produce warnings of errors in filefunctions.php line 126.
But only after I've added the curl.
developer
Usergroup: Administrator
Joined: Dec 20, 2001
Location: Diamond Springs, California
Total Topics: 61
Total Comments: 7868
And how did you add the curl? Didn't appear that simple at a glance.
Member
Usergroup: Customer
Joined: Oct 24, 2004
Location: Sweden
Total Topics: 5
Total Comments: 12
Added @ in filefunctions.php line 126:
$filecontents = @file_get_contents($url);
(As it was in earlier versions for example 3.14)
developer
Usergroup: Administrator
Joined: Dec 20, 2001
Location: Diamond Springs, California
Total Topics: 61
Total Comments: 7868
That doesn't do anything, @ is simply error supression. The curl library -- if your host supports it -- would be the only way to do do link checks or anything else that requries grabbing a remote url when your host has disabled fopen url wrappers. And surely if your host does support them, it wouldn't give an error.
Member
Usergroup: Customer
Joined: Oct 24, 2004
Location: Sweden
Total Topics: 5
Total Comments: 12
Well the Get META function works well with @ in that place. Without the @, it doesn't. I have no idea why, just thought reporting this could be helpful in some way.