Webmastersite.net
Register Log In

Bug in RSS Feed when usedetails=1
Ampersands replaced multiple times

Comments on Bug in RSS Feed when usedetails=1

flyingpylon
Member

Usergroup: Customer
Joined: Dec 12, 2005

Total Topics: 11
Total Comments: 19
Posted Mar 09, 2006 - 10:45 AM:

I discovered a bug in rssfeed.php for WSNLinks 3.3.8.

If you use the "usedetails=1" parameter, ampersands in the link element get replaced up to 3 times.

First, in this line
&
is used instead of &:

if ($usedetails) $linkstuff = $settings->dirurl .'/link.php?action=detail&id='. $thisone->id;


Then, I think the real ampersand might be getting replaced with
&
on this line:

$linkstuff = htmlspecialchars(decodeit($linkstuff));


Finally, another replacement is done on this line near the end:

$thisgroup = str_replace('{THELINK}', str_replace('&', '&', $linkstuff), $thisgroup);


I decided to change
&
to & in the first instance, then removed the replace function in the third instance and things seem to work again. However, I am just listing links in my feed and none of the other types (categories, members, comments, etc.) so I would imagine some work may need to be done for them as well.
capitaine
Forum Regular

Usergroup: Customer
Joined: Aug 05, 2005

Total Topics: 94
Total Comments: 272
Posted Mar 13, 2006 - 3:36 PM:

This has NOT been fixed! I am on 3.3.9 and have just spent an hour in frustration before coming here...

Paul, can you tell me where its been fixed and maybe just give me the patch?

mad
capitaine
Forum Regular

Usergroup: Customer
Joined: Aug 05, 2005

Total Topics: 94
Total Comments: 272
Posted Mar 13, 2006 - 3:45 PM:

Well, I compared my version of rssfeed.php against what the first poster wrote and mine is slightly different, which indicates that changes have been made... but my links using 'usedetails=1'are still coming out with
&
in them rather than &

I've cleared the cache...etc... whats going wrong??
Search thread for
Download thread as
  • 0/5
  • 1
  • 2
  • 3
  • 4
  • 5



This thread is closed, so you cannot post a reply.